Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Improve /retest #27458

Merged
merged 1 commit into from
May 18, 2023
Merged

ci: Improve /retest #27458

merged 1 commit into from
May 18, 2023
+17 −14

Conversation

phlax
Copy link
Member

@phlax phlax commented May 17, 2023 •
edited
Loading

  • /retest envoy is ignored by mobile retest
  • mobile retest works with the command at the start of any line
  • /retest mobile is ignored by repokitteh
  • repokitteh is a load quieter
  • mobile creds have been restricted

this uses a forked version of the /retest module in the toolshed repo

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title ci: Improve /retest [WIP] ci: Improve /retest May 17, 2023
@phlax phlax self-assigned this May 17, 2023
@phlax
Copy link
Member Author

phlax commented May 17, 2023

/rk bless

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/bless

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/rk-bless

@repokitteh-read-only
Copy link

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #27458 was labeled by repokitteh-read-only[bot].

see: more, trace.

@phlax phlax force-pushed the retest-envoy-mobile branch 3 times, most recently from db370ad to 438687e Compare May 17, 2023 15:51
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@envoyproxy envoyproxy deleted a comment from repokitteh-read-only bot May 17, 2023
@phlax phlax force-pushed the retest-envoy-mobile branch from 438687e to a6639a0 Compare May 17, 2023 15:57
@phlax
Copy link
Member Author

phlax commented May 17, 2023

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:

😽

Caused by: a #27458 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/retest

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/restest

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/retest

@phlax
ci: Improve /retest
7a26a3d 
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the retest-envoy-mobile branch from de82e14 to 7a26a3d Compare May 17, 2023 16:10
@phlax phlax changed the title [WIP] ci: Improve /retest ci: Improve /retest May 17, 2023
@phlax
Copy link
Member Author

phlax commented May 17, 2023

cc @jpsim

@phlax
Copy link
Member Author

phlax commented May 17, 2023

/retest

@phlax phlax removed their assignment May 17, 2023
@ggreenway ggreenway merged commit 3696ca5 into envoyproxy:main May 18, 2023
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
@phlax @reskin89
ci: Improve /retest (envoyproxy#27458)
a3e5078 
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Eskin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreenway ggreenway

Assignees
No one assigned
Labels
rk:blessed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phlax @ggreenway