Revert "http: removing whitespace from appended XFF headers" #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4882bb5. Signed-off-by: Daniel Hochman <[email protected]>
danielhochman
force-pushed
the
revert-3587-xff
branch
from
934feb8 to
0569797
Compare
mattklein123
approved these changes
Jun 12, 2018
|
cc @alyssawilk |
alyssawilk
approved these changes
Jun 12, 2018
|
@mattklein123 @alyssawilk hmm do we actually need to revert this? Isn't fixing |
|
nevermind, i forgot envoy to envoy |
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Jul 10, 2018
…nvoyproxy#3587)" (envoyproxy#3609)" This reverts commit 75ca181 with minor docs edits. Signed-off-by: Alyssa Wilk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3587
Utility::getLastAddressFromXFF()should handle XFF with and without whitespace on the un-revert.Fixes #3607