bazel: additional build targets and tests (#415). #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes us to ~65% of targets. I've switched to machine generating the BUILD files based on header analysis, the Envoy file naming conventions and a hardcoded list of exceptions. The remaining targets should be much faster.
|
@lizan @PiotrSikora for review. |
lizan
reviewed
Mar 24, 2017
test/mocks/BUILD.wip
Outdated
| @@ -4,6 +4,7 @@ load("//bazel:envoy_build_system.bzl", "envoy_cc_library") | |||
|
|
|||
| envoy_cc_library( | |||
| name = "common_lib", | |||
| testonly = 1, | |||
There was a problem hiding this comment.
What is the reason to use envoy_cc_library with testonly = 1 here instead of envoy_cc_test_library?
There was a problem hiding this comment.
I wrote that rule before I added envoy_cc_test_library :) Fixed.
lizan
reviewed
Mar 24, 2017
bazel/envoy_build_system.bzl
Outdated
| @@ -29,6 +29,7 @@ def envoy_include_prefix(path): | |||
|
|
|||
| # Envoy C++ library targets should be specified with this function. | |||
| def envoy_cc_library(name, | |||
| testonly = 0, | |||
lizan
approved these changes
Mar 24, 2017
mattklein123
approved these changes
Mar 24, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Creating a Makefile for global build * Remove unecessary env and calls * Update date on license * Fix Jenkinsfile
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes us to ~65% of targets. I've switched to machine generating the BUILD files based on
header analysis, the Envoy file naming conventions and a hardcoded list of exceptions. The remaining
targets should be much faster.