http: fixing a bug in the router filter when logging response headers to upstream access logs #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
mattklein123
approved these changes
May 2, 2019
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
… to upstream access logs (envoyproxy#6785) Risk Level: Medium (will have a perf effect for folks using access logs) Testing: regression integration test Docs Changes: n/a Release Notes: n/a Fixes envoyproxy#6744 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Jeff Piazza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: Medium (will have a perf effect for folks using access logs)
Testing: regression integration test
Docs Changes: n/a
Release Notes: n/a
Fixes #6744