Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable clang based RBE in Azure pipelines #7536

Merged
merged 30 commits into from
Jul 18, 2019
Merged

ci: enable clang based RBE in Azure pipelines #7536

merged 30 commits into from
Jul 18, 2019

Conversation

lizan
Copy link
Member

@lizan lizan commented Jul 11, 2019 •
edited
Loading

Signed-off-by: Lizan Zhou [email protected]

Description:
Minimum configuration to enable RBE and run release pipeline in Azure pipelines.

Risk Level: Low
Testing:
Docs Changes: N/A
Release Notes: N/A

lizan added 4 commits July 11, 2019 10:10
@lizan
ci: evaluate Clang based RBE in Azure
f12c0aa 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
fix jobs and exclusive tests
56b5a80 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
fix env
8ab184d 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
use release
e6651e7 
Signed-off-by: Lizan Zhou <[email protected]>
jmarantz
jmarantz reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does one enable/disable RBE? Should there be an edit to the DEVELOPER.md or similar?

lizan added 17 commits July 11, 2019 14:10
@lizan
asan
617b41c 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
fix filter-example WORKSPACE
fc58f44 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
sbin in PATH
0101b22 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
Merge remote-tracking branch 'upstream/master' into rbe-clang
855f0da
@lizan
tap run in local
a30f71e 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
typo
8db22bb 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
--experimental_remote_download_outputs=minimal
dc35865 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
optimization
b5b5940 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
don't break
44b4b31 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
Merge remote-tracking branch 'upstream/master' into rbe-clang
2a0efdf
@lizan
use rbe_autoconfig
43b53ab 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
format
031fa63 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
fix mac
933bee3 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
remove unused files
598685a 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
remove old configs
9544379 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
BAZEL_COMPILER env
e367b56 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
use release
9900863 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan lizan marked this pull request as ready for review July 16, 2019 23:31
@lizan lizan changed the title ci: evaluate Clang based RBE in Azure ci: enable clang based RBE in Azure pipelines Jul 16, 2019
@lizan
Copy link
Member Author

lizan commented Jul 16, 2019

@jmarantz this is ready to review, I will try to add more docs how to use RBE as follow up.

lizan added 3 commits July 16, 2019 23:53
@lizan
don't download test binary
ac90772 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
azure disk
a2228bc 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
no compile only step
6e5a40b 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
spell
ab71a32 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan lizan mentioned this pull request Jul 17, 2019
Merged
lizan added 2 commits July 17, 2019 08:45
@lizan
run ipv6 tests
6f194d5 
Signed-off-by: Lizan Zhou <[email protected]>
@lizan
run ipv6 tests again
9f3ed6a 
Signed-off-by: Lizan Zhou <[email protected]>
lizan added a commit that referenced this pull request Jul 17, 2019
@lizan
ci: speed up release and mac run (#7612)
ef11902 
Description:
Pulling out from #7536, allowing RBE not download test binaries. Let bazel schedule test runs at same time at build proceeds to speed up. Also let us collect Bazel profile on release compiles with test.

Risk Level: Low
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <[email protected]>
jmarantz
jmarantz approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@jmarantz jmarantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think I'm unlikely to be able to put enough time into fully reviewing this as I don't have enough Bazel-fu;. Can @htuch take a look too?

I did leave a few comments.

@lizan
Copy link
Member Author

lizan commented Jul 18, 2019

@jmarantz sorry if it wasn't clear in README.md, all files in bazel/toolchains/configs are generated without manual edit.

@jmarantz
Copy link
Contributor

OK ignore my 'indentation' nits then :)

@lizan
Copy link
Member Author

lizan commented Jul 18, 2019

and cc_wrapper as well, they are not actually used but cc_config generates them, even in your local run. I'd leave them as it is as. :)

@jmarantz
Copy link
Contributor

alright then...I probably should've read the README more carefully

@lizan
Copy link
Member Author

lizan commented Jul 18, 2019

/retest
/azp run

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: format (failed build)
🔨 rebuilding ci/circleci: asan (failed build)
🔨 rebuilding ci/circleci: filter_example_mirror (failed build)
🔨 rebuilding ci/circleci: release (failed build)
🔨 rebuilding ci/circleci: tsan (failed build)
🔨 rebuilding ci/circleci: build_image (failed build)
🔨 rebuilding ci/circleci: clang_tidy (failed build)
🔨 rebuilding ci/circleci: compile_time_options (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)
🔨 rebuilding ci/circleci: api (failed build)
🔨 rebuilding ci/circleci: docs (failed build)
🔨 rebuilding ci/circleci: ipv6_tests (failed build)

🐱

Caused by: a #7536 (comment) was created by @lizan.

see: more, trace.

@lizan lizan merged commit 14c5371 into envoyproxy:master Jul 18, 2019
@lizan
Copy link
Member Author

lizan commented Jul 18, 2019

Merging this to roll out RBE runs on master. Azure pipelines are not marked required so it should not block PRs. Let's iterate from here.

@lizan lizan deleted the rbe-clang branch July 18, 2019 21:42
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Jul 22, 2019
@lizan @TAOXUY
ci: speed up release and mac run (envoyproxy#7612)
492613c 
Description:
Pulling out from envoyproxy#7536, allowing RBE not download test binaries. Let bazel schedule test runs at same time at build proceeds to speed up. Also let us collect Bazel profile on release compiles with test.

Risk Level: Low
Testing:
Docs Changes:
Release Notes:

Signed-off-by: Lizan Zhou <[email protected]>
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Jul 22, 2019
@lizan @TAOXUY
ci: enable clang based RBE in Azure pipelines (envoyproxy#7536)
bd23aef 
Description:
Minimum configuration to enable RBE and run release pipeline in Azure pipelines.

Risk Level: Low
Testing:
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Lizan Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarantz jmarantz jmarantz approved these changes

Assignees

@jmarantz jmarantz

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizan @jmarantz @htuch