feat: support HPA in helm chart #5127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5127 +/- ##
==========================================
- Coverage 66.89% 66.87% -0.03%
==========================================
Files 210 210
Lines 33027 33027
==========================================
- Hits 22093 22086 -7
- Misses 9593 9598 +5
- Partials 1341 1343 +2 ☔ View full report in Codecov by Sentry. |
|
thanks @Dean-Coakley this looks good ! can you add a test in https://github.com/envoyproxy/gateway/tree/main/test/helm |
arkodg
reviewed
Jan 22, 2025
guydc
reviewed
Jan 22, 2025
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Dean-Coakley
force-pushed
the
add-hpa-helm-chart
branch
from
704a1ec to
4536daf
Compare
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Signed-off-by: Dean Coakley <[email protected]>
Dean-Coakley
force-pushed
the
add-hpa-helm-chart
branch
from
e589a5b to
9b20d0e
Compare
sanposhiho
reviewed
Feb 11, 2025
| {{- if .Values.hpa.minReplicas }} | ||
| minReplicas: {{ .Values.hpa.minReplicas }} | ||
| {{- end }} | ||
| maxReplicas: {{ .Values.hpa.maxReplicas }} |
There was a problem hiding this comment.
Suggested change
| maxReplicas: {{ .Values.hpa.maxReplicas }} | |
| {{- if .Values.hpa.maxReplicas }} | |
| maxReplicas: {{ .Values.hpa.maxReplicas }} | |
| {{- end }} |
missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4929
Release Notes: Yes