Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Minor cleanups for progress #309

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Conversation

phlax
Copy link
Member

@phlax phlax commented Dec 15, 2020

Fix #299

Signed-off-by: Ryan Northey <[email protected]>
@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #309 (4c82e96) into main (74fab1c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   50.60%   50.54%   -0.06%     
==========================================
  Files         117      117              
  Lines        3381     3385       +4     
==========================================
  Hits         1711     1711              
- Misses       1670     1674       +4     
Impacted Files Coverage Δ
ui/src/network/modals.js 15.78% <ø> (ø)
ui/src/service/modals.js 11.11% <ø> (ø)
ui/src/shared/container.js 7.40% <0.00%> (-0.93%) ⬇️
ui/src/shared/modal.js 11.84% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fab1c...4c82e96. Read the comment docs.

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax merged commit cf9de41 into envoyproxy:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix success state on progress bar
2 participants