-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public docker image #57
Comments
Now that #58 is in, could we have an automatic build for this? I'm happy to help set that up, but not sure what backend infrastructure is available. For now I'm going to build my own image, but would be nice to have a shared one to reference. |
@stevesloka This seems to be one of the few envoy-related projects missing from the lyft namespace on docker hub. Like you, I'm building my own as a base, but would certainly use a public "official" one if it existed. |
Any news on this issue? It would be great to have it publicly available. |
@psalaberria002 we have not allocated resources to make this happen. However, this should not be too hard to accomplished. If there is someone around that would like to setup the CI plumbing to do so (push image to dockerhub on commit to master) we can work with them to get dockerhub credentials on CI to push to Lyft's org. |
Travis build, test and deploy on merge to master? Do you have any recommended tool or aproach? If you could share an example Lyft repo where an image is pushed to Dockerhub that would be awesome @junr03 . |
Catching up on this issue again, happy to help out. I see a bunch of work was done in #105 so I don't want to duplicate the effort. It seems the work steps are:
|
Sorry this fell off my radar. I will start the discussion internally at Lyft on moving this project to the Envoy org. |
@stevesloka we are good to do the transfer. I will get this going this week. |
OK as you can see the repo has transferred. @stevesloka are you interested in helping pushing forward a whole bunch of cleanup here? We should move CI over to either GH actions or AZP and then we can work on all of the docker issues. Let me know what you need and we can get you setup. Feel free to chat with my on Envoy slack. Thank you!!! |
Thanks @mattklein123! I'll put some PRs together. 😀 |
It's amazing that I am googling for a rate limit solution and found this issue brought back to life! Thank you guys and I'm really looking forward for an official docker image! |
Thanks for merging @mattklein123, I've got some GitHub actions coming next for building/pushing images. |
…for merges as well as manage building images for releases (envoyproxy#57) Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: Steve Sloka <[email protected]>
Is there a public docker image that we can use? I checked dockerhub.com and there are many images there built by 3rd parties, but I could not find one from Lyft.
The text was updated successfully, but these errors were encountered: