Remove certificate parsing in Entertainment Mode #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be needed to control Hue and it prevents build on older mbedtls versions
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 80.79% 80.81% +0.01%
==========================================
Files 101 101
Lines 9311 9309 -2
==========================================
Hits 7523 7523
+ Misses 1788 1786 -2
Continue to review full report at Codecov.
|
enwi
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to updating OpenRGB to pull in the latest version of hueplusplus and was working on getting it building on my GitLab CI under multiple Linux distributions. The certificate parsing in mbedtls wasn't available in older distros, kept getting build errors from undefined symbols. I took this section out of EntertainmentMode.cpp and tested it on multiple platforms and it does not appear to affect Philips Hue communication so I think it is safe to remove. This way the library will build on more distributions.