Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

workflows, xcop #36

Merged
merged 11 commits into from
Jun 1, 2023
Merged

workflows, xcop #36

merged 11 commits into from
Jun 1, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jun 1, 2023

closes #27


PR-Codex overview

This PR includes various updates and improvements to the codebase. The main changes are:

Detailed summary

  • Renamed package io.github.eocqrs.qce to io.github.eocqrs.events
  • Added Event interface method submitTo to submit event to related resource
  • Added EventChain interface for managing event chains
  • Added Resource interface with generic type parameter X
  • Added User interface that extends Resource and EnUser class that implements it
  • Added ChangeUsername event class that implements Event and changes the username of a User
  • Added UserChain class that implements EventChain for managing chains of User events
  • Updated LICENSE file
  • Updated CI/CD workflows to use mvn clean install -Pinvoker -DskipTests instead of mvn clean install
  • Updated rultor.yml file to include sensitive assets and release script
  • Added ChangeUsernameTest class to test ChangeUsername event class
  • Removed unused files

The following files were skipped due to too many changes: src/main/java/io/github/eocqrs/events/EventChain.java, src/it/settings.xml, src/it/events/pom.xml, pom.xml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Jun 1, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2b62e2) 0.00% compared to head (6505e90) 0.00%.

❗ Current head 6505e90 differs from pull request most recent head f387955. Consider uploading reports for the commit f387955 to get more accurate results

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #36   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself
Copy link
Collaborator

zoeself commented Jun 1, 2023

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-06-04T11:22:24.294860.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel h1alexbel linked an issue Jun 1, 2023 that may be closed by this pull request
@h1alexbel h1alexbel merged commit e69c4b4 into master Jun 1, 2023
@h1alexbel h1alexbel deleted the poc branch June 1, 2023 13:16
@zoeself
Copy link
Collaborator

zoeself commented Jun 1, 2023

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkstyle xcop GHA
3 participants