Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to use a plain string for eosc tx push #131

Merged
merged 2 commits into from
May 17, 2019

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented May 4, 2019

The feature is heuristics based, if the first argument is an existing file, it is used right away. Otherwise, if it looks like a JSON string (really basic checks enough to avoid ambiguity with a plain filename), then the input is considered a JSON transaction. Otherwise, an error is thrown.

Fixes #126

The feature is heuristics based, if the first argument is an existing
file, it is used right away. Otherwise, if it looks like a JSON string
(really basic checks enough to avoid ambiguity with a plain filename), then
the input is considered a JSON transaction. Otherwise, an error is thrown.

Fixes #126
@maoueh maoueh requested a review from abourget May 4, 2019 04:23
@maoueh maoueh merged commit 8f2dc93 into master May 17, 2019
@maoueh maoueh deleted the feature/push-trx-as-string branch May 17, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Pass transaction by string
1 participant