Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sortable table #153

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Sortable table #153

merged 2 commits into from
Sep 4, 2020

Conversation

tetogomez
Copy link
Member

Sortable table

What does this PR do?

  • Add logic to sort table values when user click column
  • refactor footer
  • create utils to handler common styles

Steps to test

  1. yarn
  2. yarn start
  3. go to localhost:3000

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

xavier506
xavier506 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work! 💯

@xavier506 xavier506 merged commit 141dd15 into develop Sep 4, 2020
@xavier506 xavier506 deleted the fix/sort-table branch September 4, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@murillojorge murillojorge Awaiting requested review from murillojorge

@adriexnet adriexnet Awaiting requested review from adriexnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetogomez @xavier506