Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add warning for exchange with amount higher than user balance #188

Merged
merged 2 commits into from
Sep 12, 2020
Merged

feat: add warning for exchange with amount higher than user balance #188

merged 2 commits into from
Sep 12, 2020

Conversation

adriexnet
Copy link
Collaborator

GH Issue

Resolve #93

What does this PR do?

Add warning for exchange with amount higher than user balance

Steps to test

  1. yarn start
  2. navigate to http://localhost:3000/exchange
  3. login
  4. Enter an amount higher than your balance

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@xavier506
Copy link
Member

LGTM

can we perform the same balance check for add liquidity?

@xavier506
Copy link
Member

@adriexnet

please check out this error

image

I picked a token and then hit the
image button and then tried to exchange

@xavier506 xavier506 self-requested a review September 11, 2020 03:46
@adriexnet
Copy link
Collaborator Author

@adriexnet

please check out this error

image

I picked a token and then hit the
image button and then tried to exchange

Nice catch, I did a new commit to fix it
Thanks

xavier506
xavier506 approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 15431c6 into develop Sep 12, 2020
@xavier506 xavier506 deleted the feature/warning-for-large-transaccitions branch September 19, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@tetogomez tetogomez tetogomez approved these changes

@murillojorge murillojorge Awaiting requested review from murillojorge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning for large transaccitions
3 participants
@adriexnet @xavier506 @tetogomez