Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table label column #203

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Table label column #203

merged 1 commit into from
Sep 20, 2020

Conversation

tetogomez
Copy link
Member

GH Issue

What does this PR do?

  • Add i18n Chinese for table label column

Steps to test

  1. yarn start
  2. go to localhost:3000
  3. select Chinese language

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

xavier506
xavier506 approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xavier506 xavier506 merged commit 2c1d079 into develop Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 approved these changes

@murillojorge murillojorge Awaiting requested review from murillojorge

@adriexnet adriexnet Awaiting requested review from adriexnet

@sergioyuhjtman sergioyuhjtman Awaiting requested review from sergioyuhjtman

@mmileo mmileo Awaiting requested review from mmileo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetogomez @xavier506