Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange #232

Merged
merged 2 commits into from
Oct 11, 2020
Merged

Exchange #232

merged 2 commits into from
Oct 11, 2020

Conversation

tetogomez
Copy link
Member

GH Issue

What does this PR do?

  • handle infinite loop when user change input value
  • remove unnecessary states
  • refactor exchange input values logic

Steps to test

  1. yarn start
  2. go to localhost:3000
  3. test exchange page

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

xavier506
xavier506 reviewed Oct 11, 2020
View reviewed changes
src/routes/Evodex/BackLayer/Exchange/ExchangeBackLayer.js
}))
}
}

console.log('current value:', stopCallback)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetogomez do we need this here?

@xavier506 xavier506 merged commit de78f33 into develop Oct 11, 2020
@xavier506 xavier506 deleted the fix/exchange-wrong-behavior branch October 11, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier506 xavier506 xavier506 left review comments

@adriexnet adriexnet adriexnet approved these changes

@sergioyuhjtman sergioyuhjtman Awaiting requested review from sergioyuhjtman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetogomez @adriexnet @xavier506