Add evmtx actions processing #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhag
reviewed
Jan 19, 2024
| @@ -196,10 +195,15 @@ class ship_receiver_plugin_impl : std::enable_shared_from_this<ship_receiver_plu | |||
| channels::native_trx native_trx = {trace.id, trace.cpu_usage_us, trace.elapsed}; | |||
| const auto& actions = trace.action_traces; | |||
| //SILK_DEBUG << "Appending transaction "; | |||
| auto it = std::find_if(actions.begin(), actions.end(), [&](const auto& act) -> bool { | |||
There was a problem hiding this comment.
Maybe later on we can find some optimization to quickly know that we are at an EOS EVM version greater than 0 and then simply avoid doing this additional linear scan through the actions of the transaction trace.
arhag
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.