Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default page. #165

Closed
wants to merge 1 commit into from
Closed

Fix default page. #165

wants to merge 1 commit into from

Conversation

Duracell19
Copy link
Collaborator

closed #162

@Duracell19 Duracell19 force-pushed the bugfix/Incorrect_navigation_after_login branch from 8f336c0 to 73b832f Compare May 5, 2020 13:56
@fryette
Copy link
Collaborator

fryette commented May 5, 2020

the issue here is that all pages after logout should be destroyed/ why pages are not destroyed?

@fryette fryette self-requested a review May 5, 2020 19:08
fryette
fryette requested changes May 5, 2020
View reviewed changes
ecommers/lib/ui/pages/more_page.dart
@@ -97,6 +100,8 @@ class MorePage extends StatelessWidget {
}

Future logOutPressHandler() async {
tabChanged(0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all providers should be destroyed after logout.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don;t need to do this

@Duracell19 Duracell19 force-pushed the bugfix/Incorrect_navigation_after_login branch from 73b832f to 7dc28b4 Compare May 6, 2020 05:15
@Duracell19 Duracell19 closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkul qkul qkul left review comments

@fryette fryette fryette requested changes

@amarchenko25 amarchenko25 Awaiting requested review from amarchenko25

@Platton96 Platton96 Awaiting requested review from Platton96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect navigation after login
3 participants
@Duracell19 @fryette @qkul