Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sonar CRD to Consume OIDC Client Secret from Kubernetes Secrets #28

Closed
zmotso opened this issue Jan 16, 2025 · 0 comments · Fixed by #29
Closed

Update Sonar CRD to Consume OIDC Client Secret from Kubernetes Secrets #28

zmotso opened this issue Jan 16, 2025 · 0 comments · Fixed by #29
Labels
enhancement New feature or request

Comments

@zmotso
Copy link
Contributor

zmotso commented Jan 16, 2025

Is your feature request related to a problem? Please describe.
The kind: Sonar Custom Resource Definition (CRD) currently includes sensitive data directly within its configuration under the OIDC section, specifically the sonar.auth.oidc.clientSecret.secured key. To enhance the security posture and align with Kubernete's best practices, it is essential to modify the Sonar CRD to consume the OIDC client secret from Kubernetes Secrets rather than storing it directly in the configuration. This change aims to secure sensitive information effectively by leveraging Kubernetes's native secret management capabilities.

Describe the solution you'd like
There is the possibility of setting up some secured Sonar settings from the Kubernetes Secret.

Describe alternatives you've considered
Set secured value directly in the Sonar CR.

@zmotso zmotso added the enhancement New feature or request label Jan 16, 2025
zmotso added a commit that referenced this issue Jan 16, 2025
Add `valueRef` for `Sonar.spec.settings` configuration.
This allows loading settings from a Secret or ConfigMap.
zmotso added a commit that referenced this issue Jan 16, 2025
Add `valueRef` for `Sonar.spec.settings` configuration.
This allows loading settings from a Secret or ConfigMap.
@SergK SergK closed this as completed in #29 Jan 17, 2025
SergK pushed a commit that referenced this issue Jan 17, 2025
Add `valueRef` for `Sonar.spec.settings` configuration.
This allows loading settings from a Secret or ConfigMap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant