discojs/AsyncInformant: unused

epfml · Jul 22, 2024 · 7730c4a · 7730c4a
1 parent e26885f
commit 7730c4a
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 137 deletions.
diff --git a/discojs/src/aggregator/base.ts b/discojs/src/aggregator/base.ts
@@ -1,6 +1,6 @@
 import { Map, Set } from 'immutable'
 
-import type { client, AsyncInformant } from '../index.js'
+import type { client } from '../index.js'
 
 import { EventEmitter } from '../utils/event_emitter.js'
 
@@ -31,8 +31,6 @@ export abstract class Base<T> extends EventEmitter<{'aggregation': T }> {
   // communication round -> NodeID -> T
   protected contributions: Map<number, Map<client.NodeID, T>>
 
-  protected informant?: AsyncInformant<T>
-
   /**
    * The current aggregation round, used for assessing whether a node contribution is recent enough
    * or not.
@@ -82,10 +80,6 @@ export abstract class Base<T> extends EventEmitter<{'aggregation': T }> {
    */
   abstract aggregate (): void
 
-  registerObserver (informant: AsyncInformant<T>): void {
-    this.informant = informant
-  }
-
   /**
    * Returns whether the given round is recent enough, dependent on the
    * aggregator's round cutoff.
@@ -178,7 +172,6 @@ export abstract class Base<T> extends EventEmitter<{'aggregation': T }> {
       this._round++
       this.contributions = Map()
     }
-    this.informant?.update()
   }
 
   /**

diff --git a/discojs/src/aggregator/mean.ts b/discojs/src/aggregator/mean.ts
@@ -108,7 +108,6 @@ export class MeanAggregator extends Aggregator<WeightsContainer> {
 
     this.contributions = this.contributions.setIn([0, nodeId], contribution);
 
-    this.informant?.update();
     if (this.isFull()) this.aggregate();
 
     return true;

diff --git a/discojs/src/aggregator/secure.ts b/discojs/src/aggregator/secure.ts
@@ -75,7 +75,6 @@ export class SecureAggregator extends Aggregator<WeightsContainer> {
       contribution,
     );
 
-    this.informant?.update();
     if (this.isFull()) this.aggregate();
 
     return true;

diff --git a/discojs/src/async_informant.spec.ts b/discojs/src/async_informant.spec.ts
diff --git a/discojs/src/async_informant.ts b/discojs/src/async_informant.ts
diff --git a/discojs/src/index.ts b/discojs/src/index.ts
@@ -7,7 +7,6 @@ export * as client from './client/index.js'
 export * as aggregator from './aggregator/index.js'
 
 export { WeightsContainer, aggregation } from './weights/index.js'
-export { AsyncInformant } from './async_informant.js'
 export { Logger, ConsoleLogger } from './logging/index.js'
 export { Memory, type ModelInfo, type Path, type ModelSource, Empty as EmptyMemory } from './memory/index.js'
 export { Disco, RoundLogs } from './training/index.js'

diff --git a/server/src/router/federated/server.ts b/server/src/router/federated/server.ts
@@ -11,10 +11,9 @@ import type {
   MetadataValue
 } from '@epfml/discojs'
 import {
+  aggregator as aggregators,
   client,
   serialization,
-  AsyncInformant,
-  aggregator as aggregators,
 } from '@epfml/discojs'
 
 import { Server } from '../server.js'
@@ -50,10 +49,6 @@ export class Federated extends Server {
    * with the most recent result.
    */
   private results = Map<TaskID, Promise<WeightsContainer>>()
-  /**
-   * Training informants for each hosted task.
-   */
-  private informants = Map<TaskID, AsyncInformant<WeightsContainer>>()
   /**
    * Contains metadata used for training by clients for a given task and round.
    * Stored by task id, round number, node id and metadata key.
@@ -113,7 +108,6 @@ export class Federated extends Server {
     const aggregator = new aggregators.MeanAggregator(undefined, 1, 'relative')
 
     this.aggregators = this.aggregators.set(task, aggregator)
-    this.informants = this.informants.set(task, new AsyncInformant(aggregator))
     this.rounds = this.rounds.set(task, 0)
 
     void this.storeAggregationResult(task, aggregator)