UI tweaks #692
Merged
UI tweaks #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
7 tasks
tharvik
force-pushed
the
NAN-prerelease-fixes-tharvik
branch
from
0b51367 to
b90b193
Compare
…or when loading a new page
tharvik
approved these changes
Jul 11, 2024
| } | ||
|
|
||
| const props = defineProps<Props>() | ||
| const isCurrentStep = toRef(props, 'currentStep') |
There was a problem hiding this comment.
looks weird to me, why do you need it? consider changing the "currentStep" instead and use it directly
There was a problem hiding this comment.
Yea I'm not sure of that but I first tried using currentStep directly and it wasn't reactive so it was stuck to step 0.
https://stackoverflow.com/questions/70631273/vuejs3-reactivity-of-props-object
|
@tharvik I'm merging this PR right now to have more time for internal feedback and I'll create a new PR to address your answers if needed (as well as feedback) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691
Changed the training board metrics and added tool tip informations
