Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display landing page before server boots #720

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Conversation

JulienVig
Copy link
Collaborator

@JulienVig JulienVig commented Jul 23, 2024

  • Rather than blocking the website to load until the server booted and pushed the discollaboratives, I'm moving the loading indicator to where the discollaboratives are actually needed: the task list page and the testing page (which list models to download)
    Screenshot 2024-07-23 at 13 36 03
    Screenshot 2024-07-23 at 13 36 33
  • Make the DISCO GIF responsive (currently larger than the screen on small devices)
  • Add a note on the collaborative button to explain how collaborative training behaves if there is a single participant.
    Screenshot 2024-07-23 at 18 21 13

@martinjaggi martinjaggi changed the title Display langing page before server boots Display landing page before server boots Jul 23, 2024
Base automatically changed from 694-decentralized-fail-julien to develop July 23, 2024 14:35
@tharvik tharvik added this to the v4.0.0 milestone Jul 23, 2024
@tharvik tharvik removed this from the v4.0.0 milestone Jul 23, 2024
@JulienVig JulienVig marked this pull request as ready for review July 23, 2024 16:22
@JulienVig JulienVig requested a review from tharvik July 23, 2024 16:22
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@JulienVig JulienVig merged commit 86c6a88 into develop Jul 24, 2024
23 checks passed
@JulienVig JulienVig deleted the nan-move-loading-julien branch July 24, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants