-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign of homepage #845
Open
iamsherlocked1891
wants to merge
21
commits into
develop
Choose a base branch
from
627-homepage-remake-olena
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Redesign of homepage #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharvik
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work, that makes a way more pro homepage, love it!
a few comments, mostly on style, aside from the text consistency on the homepage nothing blocking
while at it, you can also remove src/assets/{gif/DiscoGIF,svg/Disco,AboutUsIcon}.vue
now that it is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the Homepage:
1. Added a one-sentence description of DISCO:
A brief description of Disco has been included on the homepage.
2. Moved key information from the Info section:
Essential information previously located in the Info section has been moved to the homepage to improve visibility and accessibility.
3. Replaced GIF logo with SVG:
The DISCO logo in GIF format has been replaced with an SVG version.
4. Relocated the "Get Started" section:
The "Get Started" section has been moved to the bottom of the page to streamline the layout.
Hompage before:
Homepage after:
Other Changes:
Note on the MLO Logo:
There is a minor issue with the MLO logo: In the original SVG file, the laboratory name text is black, which works well for the light theme. However, when switching to a dark theme, the text should turn white for better visibility. Unfortunately, I was unable to achieve this result.