Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign of homepage #845

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Conversation

iamsherlocked1891
Copy link
Collaborator

Changes to the Homepage:

1. Added a one-sentence description of DISCO:
A brief description of Disco has been included on the homepage.
2. Moved key information from the Info section:
Essential information previously located in the Info section has been moved to the homepage to improve visibility and accessibility.
3. Replaced GIF logo with SVG:
The DISCO logo in GIF format has been replaced with an SVG version.
4. Relocated the "Get Started" section:
The "Get Started" section has been moved to the bottom of the page to streamline the layout.

Hompage before:

before

Homepage after:

after_1

after_2

after_3

Other Changes:

  1. The "Info Section" icon has been removed from the sidebar
  2. On the About Page, laboratory logos have been updated and replaced with SVG versions.

Note on the MLO Logo:

There is a minor issue with the MLO logo: In the original SVG file, the laboratory name text is black, which works well for the light theme. However, when switching to a dark theme, the text should turn white for better visibility. Unfortunately, I was unable to achieve this result.

@iamsherlocked1891 iamsherlocked1891 marked this pull request as ready for review January 13, 2025 21:54
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work, that makes a way more pro homepage, love it!

a few comments, mostly on style, aside from the text consistency on the homepage nothing blocking

while at it, you can also remove src/assets/{gif/DiscoGIF,svg/Disco,AboutUsIcon}.vue now that it is unused

webapp/src/assets/svg/DiscoLogoBoule.vue Outdated Show resolved Hide resolved
webapp/src/assets/svg/MLOLogo.vue Show resolved Hide resolved
webapp/src/assets/svg/LightLogo.vue Outdated Show resolved Hide resolved
webapp/src/assets/svg/DiscoLogoBoule.vue Outdated Show resolved Hide resolved
webapp/src/assets/svg/DiscoLogoBoule.vue Outdated Show resolved Hide resolved
webapp/src/components/home/Home.vue Outdated Show resolved Hide resolved
webapp/src/components/home/Home.vue Outdated Show resolved Hide resolved
webapp/src/components/home/Home.vue Outdated Show resolved Hide resolved
webapp/src/components/home/Home.vue Show resolved Hide resolved
webapp/src/components/home/Home.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants