Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save language preference for user #1080

Merged
merged 5 commits into from
Sep 30, 2023
Merged

save language preference for user #1080

merged 5 commits into from
Sep 30, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Sep 24, 2023

closes #1076

@jeriox jeriox requested a review from felixrindt September 24, 2023 22:16
@coveralls
Copy link

coveralls commented Sep 24, 2023 •
edited
Loading

Coverage Status

coverage: 88.719% (+0.1%) from 88.623% when pulling cdde716 on user-language into 57ba281 on main.

felixrindt
felixrindt reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to have a look with my computer too

ephios/core/services/notifications/backends.py Outdated Show resolved Hide resolved
ephios/extra/middleware.py Outdated Show resolved Hide resolved
felixrindt
felixrindt approved these changes Sep 30, 2023
View reviewed changes
ephios/core/forms/users.py Outdated Show resolved Hide resolved
@jeriox jeriox enabled auto-merge (squash) September 30, 2023 13:17
@jeriox jeriox disabled auto-merge September 30, 2023 13:19
@jeriox jeriox enabled auto-merge (squash) September 30, 2023 14:10
@jeriox jeriox merged commit 8964bc9 into main Sep 30, 2023
@jeriox jeriox deleted the user-language branch September 30, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect user language
3 participants
@jeriox @coveralls @felixrindt