Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont clear names on missing oidc claims #1087

Merged
merged 1 commit into from
Oct 2, 2023
Merged

dont clear names on missing oidc claims #1087

merged 1 commit into from
Oct 2, 2023

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Oct 1, 2023 •
edited
Loading

Having these claim names hardcoded is still somewhat hacky. We'd need to change this with the OIDC rework.
Nextcloud for example only has the full name inside the name claim:

https://github.com/H2CK/oidc/wiki/User-Documentation#scopes

@felixrindt felixrindt added the [C] bug Something isn't working label Oct 1, 2023
@felixrindt felixrindt requested a review from jeriox October 1, 2023 20:29
@coveralls
Copy link

Coverage Status

coverage: 88.644% (-0.04%) from 88.686% when pulling 5baa299 on fix-oidc-name-updating into af98f8a on main.

@felixrindt felixrindt merged commit fdd9cf5 into main Oct 2, 2023
@felixrindt felixrindt deleted the fix-oidc-name-updating branch October 2, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
[C] bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixrindt @coveralls @jeriox