Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customizable OIDC #1088

Merged
merged 23 commits into from
Oct 22, 2023
Merged

customizable OIDC #1088

merged 23 commits into from
Oct 22, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Oct 1, 2023 •
edited
Loading

felixrindt
felixrindt reviewed Oct 7, 2023
View reviewed changes
ephios/extra/auth.py Outdated Show resolved Hide resolved
@jeriox jeriox force-pushed the custom-oidc-client branch from 1cffb75 to 5da5385 Compare October 7, 2023 22:52
@coveralls
Copy link

coveralls commented Oct 7, 2023 •
edited
Loading

Coverage Status

coverage: 87.368% (-0.4%) from 87.802% when pulling da87ab5 on custom-oidc-client into 55885c0 on main.

@jeriox jeriox marked this pull request as ready for review October 8, 2023 22:04
jeriox
jeriox commented Oct 8, 2023
View reviewed changes
ephios/core/urls.py Outdated Show resolved Hide resolved
@jeriox jeriox force-pushed the custom-oidc-client branch from a0380f8 to 23d8343 Compare October 19, 2023 14:55
@jeriox jeriox requested a review from felixrindt October 19, 2023 15:12
@jeriox jeriox force-pushed the custom-oidc-client branch from 8d06a47 to 758b58d Compare October 19, 2023 21:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2023
View reviewed changes
ephios/core/views/auth.py Outdated Show resolved Hide resolved
@jeriox jeriox mentioned this pull request Oct 19, 2023
Closed
@jeriox jeriox force-pushed the custom-oidc-client branch from 8b17dd2 to 7bb386f Compare October 19, 2023 23:52
felixrindt
felixrindt requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation. Esp. how to configure the Identity provider (redirect url etc.)

felixrindt
felixrindt approved these changes Oct 22, 2023
View reviewed changes
docs/admin/additional_features/oidc.rst Outdated Show resolved Hide resolved
docs/admin/additional_features/oidc.rst Outdated Show resolved Hide resolved
docs/admin/additional_features/oidc.rst Show resolved Hide resolved
@felixrindt felixrindt added the [C] feature New feature or request label Oct 22, 2023
@jeriox jeriox enabled auto-merge (squash) October 22, 2023 16:51
@jeriox jeriox merged commit c6e6d4f into main Oct 22, 2023
@jeriox jeriox deleted the custom-oidc-client branch October 22, 2023 16:56
@jeriox jeriox linked an issue Oct 23, 2023 that may be closed by this pull request
Place users created from OIDC in a group automatically #1070
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
[C] feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place users created from OIDC in a group automatically
3 participants
@jeriox @coveralls @felixrindt