Fix teams structure fullness display #1388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381. Fixes #1382.
This is just a quick fix. We're unhappy with the inconsistencies in the assignment, fullness-determination and counts between the signup structures and therefore plan to follow up with a design session (considering all possible combinations and scenarios and what behavior we expect of them), a rewrite of much of the logic touched here and user documentation.
(There is for example another bug affecting the "full"-state for atomic blocks in the complex structure, which can't be fixed without a more thoughtful rewrite of the matching algorithms.)
@lukasrad02 feel free to test this. As we discussed in our call, this should fix the issues you're currently having with your events.