Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teams structure fullness display #1388

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Oct 21, 2024

Fixes #1381. Fixes #1382.

This is just a quick fix. We're unhappy with the inconsistencies in the assignment, fullness-determination and counts between the signup structures and therefore plan to follow up with a design session (considering all possible combinations and scenarios and what behavior we expect of them), a rewrite of much of the logic touched here and user documentation.

(There is for example another bug affecting the "full"-state for atomic blocks in the complex structure, which can't be fixed without a more thoughtful rewrite of the matching algorithms.)

@lukasrad02 feel free to test this. As we discussed in our call, this should fix the issues you're currently having with your events.

@felixrindt felixrindt added the [C] bug Something isn't working label Oct 21, 2024
@felixrindt felixrindt requested a review from jeriox October 21, 2024 15:51
@coveralls
Copy link

coveralls commented Oct 21, 2024

Coverage Status

coverage: 85.283% (-0.04%) from 85.323%
when pulling df80fb6 on fix-teams-fullness-display
into d719292 on main.

@felixrindt felixrindt force-pushed the fix-teams-fullness-display branch from bf44f62 to df80fb6 Compare October 21, 2024 16:46
@felixrindt felixrindt enabled auto-merge (rebase) October 21, 2024 16:46
@felixrindt felixrindt merged commit eb1667a into main Oct 21, 2024
14 checks passed
@felixrindt felixrindt deleted the fix-teams-fullness-display branch October 21, 2024 16:53
@lukasrad02
Copy link
Contributor

I've noticed that there is still an inconsistency in the displayed number of missing people. Is that intended?

Screenshot from 2024-10-22 13-04-31

Scenario:

  • Direct Confirmation, two named teams, each min 1, max 1, no required qualifications
  • Participant "Admin" signed up for team A explicitly
  • Participant "User" signed up without choosing a team
  • The shift view shows 2/2 participants in total (and 0/2 for the second shift)
  • The event list shows 3 missing participants, although it should only be 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] bug Something isn't working
Projects
None yet
4 participants