Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventtype badge visual fixes #1435

Merged
merged 3 commits into from
Dec 3, 2024
Merged

eventtype badge visual fixes #1435

merged 3 commits into from
Dec 3, 2024

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Nov 28, 2024

Create a new eventtype with a long title and you'll see visual glitches on the homepage and the event list, esp. on small screens.
This doesn't make it perfect, but it is an improvement I would say. Please try various event type name lengths and various viewport widths.

@felixrindt felixrindt added the [C] design/ui Enhancement of existing views label Nov 28, 2024
@felixrindt felixrindt requested a review from jeriox November 28, 2024 12:19
@coveralls
Copy link

coveralls commented Nov 28, 2024

Coverage Status

coverage: 84.87% (-0.02%) from 84.885%
when pulling c981d2b on eventtype-badge-maxwidth
into 62442ca on main.

@felixrindt felixrindt force-pushed the eventtype-badge-maxwidth branch from 11ced65 to 071657a Compare November 28, 2024 16:14
@felixrindt felixrindt marked this pull request as ready for review November 28, 2024 16:14
@felixrindt felixrindt force-pushed the eventtype-badge-maxwidth branch from 071657a to 851d77b Compare November 28, 2024 16:15
@jeriox
Copy link
Contributor

jeriox commented Nov 28, 2024

image

don't like this

(you could implement #1220) to mitigate this as it only happens at the first breakpoint where the button is shown :D

@felixrindt felixrindt force-pushed the eventtype-badge-maxwidth branch 2 times, most recently from 01d86d0 to c9ce062 Compare November 29, 2024 16:08
@felixrindt felixrindt force-pushed the eventtype-badge-maxwidth branch from 1df0522 to 99a44cf Compare December 3, 2024 17:40
@felixrindt felixrindt enabled auto-merge (rebase) December 3, 2024 17:41
@felixrindt felixrindt force-pushed the eventtype-badge-maxwidth branch from 99a44cf to c981d2b Compare December 3, 2024 17:41
@felixrindt felixrindt merged commit 21df724 into main Dec 3, 2024
15 checks passed
@felixrindt felixrindt deleted the eventtype-badge-maxwidth branch December 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] design/ui Enhancement of existing views
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Title is not Clickable
3 participants