-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eventtype badge visual fixes #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrindt
force-pushed
the
eventtype-badge-maxwidth
branch
from
November 28, 2024 16:14
11ced65
to
071657a
Compare
felixrindt
force-pushed
the
eventtype-badge-maxwidth
branch
from
November 28, 2024 16:15
071657a
to
851d77b
Compare
jeriox
reviewed
Nov 28, 2024
don't like this (you could implement #1220) to mitigate this as it only happens at the first breakpoint where the button is shown :D |
felixrindt
force-pushed
the
eventtype-badge-maxwidth
branch
2 times, most recently
from
November 29, 2024 16:08
01d86d0
to
c9ce062
Compare
jeriox
approved these changes
Dec 3, 2024
felixrindt
force-pushed
the
eventtype-badge-maxwidth
branch
from
December 3, 2024 17:40
1df0522
to
99a44cf
Compare
remove view event button in list
felixrindt
force-pushed
the
eventtype-badge-maxwidth
branch
from
December 3, 2024 17:41
99a44cf
to
c981d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new eventtype with a long title and you'll see visual glitches on the homepage and the event list, esp. on small screens.
This doesn't make it perfect, but it is an improvement I would say. Please try various event type name lengths and various viewport widths.