Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor permission management in forms #354

Merged
merged 18 commits into from
Mar 8, 2021
Merged

refactor permission management in forms #354

merged 18 commits into from
Mar 8, 2021

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Mar 7, 2021

close #299

@coveralls
Copy link

coveralls commented Mar 8, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 88.316% when pulling 689bd19 on feature/permissions into 6a8ed15 on main.

@jeriox jeriox changed the title Feature/permissions refactor permission management in forms Mar 8, 2021
@jeriox jeriox requested a review from felixrindt March 8, 2021 01:15
@jeriox jeriox marked this pull request as ready for review March 8, 2021 01:15
felixrindt
felixrindt requested changes Mar 8, 2021
View reviewed changes
ephios/core/views/eventtype.py Outdated Show resolved Hide resolved
ephios/core/views/eventtype.py Outdated Show resolved Hide resolved
ephios/core/views/eventtype.py Outdated Show resolved Hide resolved
ephios/static/ephios/js/group_form.js Outdated Show resolved Hide resolved
ephios/static/ephios/js/group_form.js Outdated Show resolved Hide resolved
ephios/core/forms/users.py Outdated Show resolved Hide resolved
ephios/core/forms/users.py Outdated Show resolved Hide resolved
felixrindt
felixrindt requested changes Mar 8, 2021
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a hassle, but I find this really improves the permission situation. 🚀

ephios/extra/mixins.py Outdated Show resolved Hide resolved
ephios/extra/mixins.py Outdated Show resolved Hide resolved
ephios/extra/permissions.py Outdated Show resolved Hide resolved
ephios/extra/permissions.py Outdated Show resolved Hide resolved
ephios/core/forms/users.py Show resolved Hide resolved
@jeriox jeriox requested a review from felixrindt March 8, 2021 19:01
@jeriox jeriox merged commit e79fee2 into main Mar 8, 2021
@jeriox jeriox deleted the feature/permissions branch March 8, 2021 21:11
@jeriox jeriox mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor role/permission system
3 participants
@jeriox @coveralls @felixrindt