Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove django-redis #800

Merged
merged 3 commits into from
Mar 3, 2023
Merged

remove django-redis #800

merged 3 commits into from
Mar 3, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Sep 17, 2022

closes #699

currently blocked by joke2k/django-environ#409

@coveralls
Copy link

coveralls commented Sep 17, 2022 •
edited
Loading

Coverage Status

Coverage: 87.925%. Remained the same when pulling 19e0608 on remove_django-redis into 8ec96bb on main.

@jeriox jeriox marked this pull request as draft September 29, 2022 14:09
@jeriox jeriox marked this pull request as ready for review March 3, 2023 17:46
@jeriox jeriox requested a review from felixrindt March 3, 2023 17:46
@jeriox jeriox enabled auto-merge (squash) March 3, 2023 17:47
@jeriox
Copy link
Contributor Author

jeriox commented Mar 3, 2023

@felixrindt blocker in depdency has been resolved

felixrindt
felixrindt approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@felixrindt felixrindt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pin django-environ to the updated release? Dependabot also created a PR for that package

@jeriox jeriox merged commit 72bbea5 into main Mar 3, 2023
@jeriox jeriox deleted the remove_django-redis branch March 3, 2023 17:51
@jeriox
Copy link
Contributor Author

jeriox commented Mar 3, 2023

rip, auto-merge was already on

@jeriox jeriox added the [C] enhancement Changes to an existing feature making it better label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrindt felixrindt felixrindt approved these changes

Assignees
No one assigned
Labels
[C] enhancement Changes to an existing feature making it better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use native redis cache backend instead of dependency
3 participants
@jeriox @coveralls @felixrindt