Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change event_action_signal interface #881

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

felixrindt
Copy link
Member

I think this change makes the interface more flexible, as receivers can reverse the url themselves or do something else entirely or just not return an action if not appropriate for that event.

@felixrindt felixrindt requested a review from jeriox February 2, 2023 16:15
@coveralls
Copy link

coveralls commented Feb 2, 2023

Coverage Status

Coverage: 87.95% (+0.001%) from 87.949% when pulling 76b380d on refactor-event-action-signal into 9ac8a22 on main.

@felixrindt felixrindt force-pushed the refactor-event-action-signal branch from d3ccbad to 67af119 Compare February 2, 2023 16:21
@felixrindt felixrindt force-pushed the refactor-event-action-signal branch from 67af119 to 76b380d Compare February 2, 2023 16:22
@jeriox
Copy link
Contributor

jeriox commented Feb 2, 2023

I think this change makes the interface more flexible, as receivers can reverse the url themselves or do something else entirely or just not return an action if not appropriate for that event.

yeah that was probably just copy and paste from the event_bulk_action where it makes sense that it is specified how the pks are transferred to the action. No one is currently using the event_action, right?

@felixrindt felixrindt merged commit 8389f0f into main Feb 2, 2023
@felixrindt felixrindt deleted the refactor-event-action-signal branch February 2, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants