Fix tr_bed parameter handling #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HudoGriz, thanks for this. We don't accept merge requests from Github but this change will be integrated as part of our next release. |
|
Forgot to follow up on this, this change was included in our recent v2.3.1 release, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've identified an issue with the handling of the
tr_bedparameter that deviates from the standard practice seen in other parts of the codebase (for example, this line).When the
tr_bedparameter is provided as an empty string in theparams-file.json, it causes an error:This pull request addresses this issue by ensuring proper handling of the tr_bed parameter when it is an empty string.
Thank you for your great work and hope this helps!
Best regards,
Blaž