-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to initialise NTEnum like NTScalar #154
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some coverage would need to be added to TestEnum
in src/p4p/test/test_nt.py
.
Just wondering if this has been resolved yet? Let me know if there is anything I can do to help. Two issues (this one and #153) can then be closed for the price of one! |
…x and value.choices, or init all fields by name
@kurup I'm happy with this PR as it is now, just needs review and approval on your end. |
When initialising an NTEnum with a python dict, it is assumed that the dict is meant for the Value.value and contains
index
andchoices
keys for the value. This PR adds ability to initialise value and any other fields of the NTEnum, similar to initialising an NTScalar.