upgrade to React 19

epicweb-dev · Dec 5, 2024 · 8bd5824 · 8bd5824
1 parent 0796f8a
commit 8bd5824
Show file tree

Hide file tree

Showing 7 changed files with 3,661 additions and 3,346 deletions.
diff --git a/epicshop/package-lock.json b/epicshop/package-lock.json
diff --git a/epicshop/package.json b/epicshop/package.json
@@ -5,9 +5,9 @@
     "test": "playwright test"
   },
   "dependencies": {
-    "@epic-web/config": "^1.11.2",
+    "@epic-web/config": "^1.16.3",
     "@epic-web/workshop-app": "^5.9.0",
     "@epic-web/workshop-utils": "^5.9.0",
-    "execa": "^9.2.0"
+    "execa": "^9.5.1"
   }
 }
diff --git a/exercises/06.optimization/01.solution.parallel/index.tsx b/exercises/06.optimization/01.solution.parallel/index.tsx
@@ -122,7 +122,7 @@ function SearchResults({
 
 function ShipDetails({ shipName }: { shipName: string }) {
 	const shipImgSrc = getImageUrlForShip(shipName, { size: 200 })
-	imgSrc(shipImgSrc)
+	void imgSrc(shipImgSrc)
 	// 🦉 play with the delay to see how it affects the loading experience
 	const ship = use(getShip(shipName, 300))
 	return (

diff --git a/exercises/06.optimization/02.problem.cache/index.tsx b/exercises/06.optimization/02.problem.cache/index.tsx
@@ -122,7 +122,9 @@ function SearchResults({
 
 function ShipDetails({ shipName }: { shipName: string }) {
 	const shipImgSrc = getImageUrlForShip(shipName, { size: 200 })
-	imgSrc(shipImgSrc)
+	// 🦉 using "void" so we don't wait for the promise, but also signal to others
+	// that we're intentionally not waiting for this promise
+	void imgSrc(shipImgSrc)
 	const ship = use(getShip(shipName))
 	return (
 		<div className="ship-info">

diff --git a/exercises/06.optimization/02.solution.cache/index.tsx b/exercises/06.optimization/02.solution.cache/index.tsx
@@ -122,7 +122,9 @@ function SearchResults({
 
 function ShipDetails({ shipName }: { shipName: string }) {
 	const shipImgSrc = getImageUrlForShip(shipName, { size: 200 })
-	imgSrc(shipImgSrc)
+	// 🦉 using "void" so we don't wait for the promise, but also signal to others
+	// that we're intentionally not waiting for this promise
+	void imgSrc(shipImgSrc)
 	const ship = use(getShip(shipName))
 	return (
 		<div className="ship-info">