Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several minor fixes to the readme and download scripts #1

Merged
merged 5 commits into from
Mar 23, 2017
Merged

Several minor fixes to the readme and download scripts #1

merged 5 commits into from
Mar 23, 2017

Conversation

jabalazs
Copy link
Contributor

No description provided.

@jabalazs
Copy link
Contributor Author

There is a line in create_data_folder.sh where a file is copied from within ~/nltk_data. What if the user doesn't have nltk installed? or if their nltk_data directory is located elsewhere? For now I left that line commented.

@jabalazs
Copy link
Contributor Author

I also noticed there is a JAVA_HOME setting in enlp/settings.py but there's no mention of installing Java on the readme file.

@jabalazs jabalazs mentioned this pull request Mar 23, 2017
Closed
@epochx epochx merged commit 622693f into epochx:master Mar 23, 2017
@jabalazs jabalazs deleted the fixes branch March 23, 2017 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabalazs @epochx