Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid transpiling transforms #63

Merged
merged 1 commit into from
May 21, 2022
Merged

feat: Avoid transpiling transforms #63

merged 1 commit into from
May 21, 2022

Conversation

eps1lon
Copy link
Owner

@eps1lon eps1lon commented May 21, 2022

Closes #62

Previously jscodeshift would transpile the transforms before using them.
This was largely unnecessary and resulted in bugs to to usage of undeclared Babel dependencies.

Tested it by running the bin without the module.exports and it failed as expected since it needs the files as CommonJS. Previously jscodeshift transpiled the transforms so we didn't catch this problem.

@eps1lon eps1lon merged commit 15ec796 into main May 21, 2022
@eps1lon eps1lon deleted the fix/no-babel-transform branch May 21, 2022 07:50
@github-actions github-actions bot mentioned this pull request May 21, 2022
@macnaughton macnaughton mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

got ERR_REQUIRE_ESM on implicit-children
1 participant