Split pedersen into stark_curve and stark_hash
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
May 9, 2022
kkovaacs
force-pushed
the
krisztian/pedersen-constants
branch
2 times, most recently
from
6198629 to
2a2d44e
Compare
kkovaacs
changed the title
pedersen into stark_curve and pedersen_hashpedersen into stark_curve and stark_hash
Mirko-von-Leipzig
approved these changes
May 11, 2022
mikdk
approved these changes
May 11, 2022
CHr15F0x
approved these changes
May 12, 2022
koivunej
reviewed
May 13, 2022
koivunej
approved these changes
May 13, 2022
kkovaacs
force-pushed
the
krisztian/pedersen-constants
branch
2 times, most recently
from
c8292f3 to
0ffbd29
Compare
stark_curve contains the math parts of the curve, and pedersen hash contains the code implementing the hash function. This will make it possible to move the pre-computation of values used by the hash function into a build script in pedersen_hash.
Instead of having the code run as an ignored unit test.
Keep the generator in case we need signatures later.
It was only being used by the benchmark.
cargo bench output:
pedersen_hash time: [44.102 us 44.112 us 44.123 us]
change: [-49.728% -49.555% -49.414%] (p = 0.00 < 0.05)
Performance has improved.
kkovaacs
force-pushed
the
krisztian/pedersen-constants
branch
from
0ffbd29 to
e32e249
Compare
koivunej
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove
curve_consts.rsand generate it from a build script instead.