syncing: refactor with tuple type #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
May 20, 2022
koivunej
commented
May 20, 2022
koivunej
commented
May 20, 2022
added 3 commits
May 20, 2022 17:23
this allows to get rid of the pairs of fields, and just have three fields in syncing::Status. found out that one cannot use deny_unknown_fields within an untagged tree, but the syncing::Status is only needs deserialize for testing.
this should make it less stressful not to have the deny_unknown_fields.
not really sure if this is a good idea. but we cannot have the flattened fields with deny_extra_fields.
koivunej
force-pushed
the
syncing_refactor
branch
from
a9f3424 to
6b37f81
Compare
Mirko-von-Leipzig
approved these changes
May 20, 2022
kkovaacs
approved these changes
May 20, 2022
CHr15F0x
approved these changes
May 20, 2022
| let latest_num = block.block_number.unwrap(); | ||
| let latest = { | ||
| let latest_hash = block.block_hash.unwrap(); | ||
| let latest_num = block.block_number.unwrap(); |
There was a problem hiding this comment.
I cannot see any regression test for the latest_num being updated. I know it seems a bit silly because that was an easy fix, but we still don't have an automated way of making sure it won't happen again in the future.
Generally I recall seeing at least another fix in the past to a regression that was not accompanied by a respective test, however now I don't remember which concrete fix it was. I think we should put more stress on tests when regressions pop up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor avoid another field modified issues in the future.