Migrate the db if it is based on a "broken" version of rev7 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
May 23, 2022
koivunej
approved these changes
May 23, 2022
CHr15F0x
force-pushed
the
CHr15F0x/fix_schema
branch
from
d9e813f to
2a99b07
Compare
kkovaacs
reviewed
May 23, 2022
- the virtual table `starknet_events_keys` remains unchanged - but as it references rowids from the old `starknet_events` table - we need to make sure that the recreated `starknet_events` table contains the same rowids - otherwise `starknet_events_keys` could contain stale data and `starknet_getEvents` could cease to retrun valid replies
CHr15F0x
force-pushed
the
CHr15F0x/fix_schema
branch
from
fbd4179 to
fa7a6e2
Compare
koivunej
approved these changes
May 24, 2022
koivunej
reviewed
May 24, 2022
This reverts commit 2a99b07.
koivunej
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the db schema contains
ON DELETE CASCADE, then this migration is a noop.