fix: temporary index used by migration #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
approved these changes
Jun 9, 2022
kkovaacs
approved these changes
Jun 9, 2022
added 2 commits
June 9, 2022 15:39
on unscientific tests this is faster (N=1). by logic this should be
faster because idx = {0, 1, 2, 3, 4} select over 90% of rows. I removed
this from the previous PR because it was not able to see this effect on
more powerful pc.
using the example simpler but committing this always-made change.
koivunej
force-pushed
the
fasta_migration_2
branch
from
1514124 to
740b630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #351 to swap the index around, hopefully making this migration faster on ram limited devices. Includes a fix to disable vacuum on
examples/migrate_dbwhich is just trying to have less mandatory patches running around.