fix(rpc): remove abi field from ContractDefinition
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the sequencer supports an optional `abi` field on the REST API, the OpenRPC spec does not mention it so we should definitely not have it as a mandatory argument. Fixes issue #369
Mirko-von-Leipzig
approved these changes
Jun 10, 2022
|
Always nice to see |
|
That's fast :) |
CHr15F0x
approved these changes
Jun 10, 2022
koivunej
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the sequencer supports an optional
abifield on the RESTAPI, the OpenRPC spec does not mention it so we should definitely not
have it as a mandatory argument.
Fixes issue #369