fix(py): find more correct gas_consumed #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
force-pushed
the
inline_more_fee_est
branch
from
2476125 to
e366938
Compare
Mirko-von-Leipzig
approved these changes
Jun 30, 2022
koivunej
force-pushed
the
inline_more_fee_est
branch
2 times, most recently
from
abe9921 to
a0d281f
Compare
koivunej
force-pushed
the
inline_more_fee_est
branch
2 times, most recently
from
bf54a91 to
5d3aa3b
Compare
this should be fixed in cairo-lang 0.9.1, there should be a triple returning api. while fixing the tests, noticed that the inevitable flooring or ceilinging of the gas_consumed will be a problem. went with flooring at the moment.
koivunej
force-pushed
the
inline_more_fee_est
branch
from
5d3aa3b to
5e77503
Compare
kkovaacs
approved these changes
Jun 30, 2022
koivunej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be fixed in cairo-lang 0.9.1, there should be a triple returning api.
Unable to reproduce the original in #412, but I would assume this now the correct version, and overall fee doesn't change.
Fixes but maybe not: #412