-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
|
4123d0c
to
64b83d5
Compare
I was wrong about this; we can provide a subset of the templates. This PR has been updated to only include the templates that we are customizing in order to check for required fields. It's still a good practice to contribute template changes upstream whenever possible to avoid drift, though; custom templates mean we will miss out on upstream template changes unless we periodically re-sync and/or add yet another complicated patching process. |
e8d10d4
to
64fe14b
Compare
2888c0c
to
1ef867e
Compare
That's what I was going to suggest. It's no more complicated that the existing patching and it makes it clear what changes we are making to the templates. It also makes it clear when we need to reconsider those changes in light up new upstream default templates which CI would stamp out before patching, as you suggest. |
302a3da
to
e1a7995
Compare
e1a7995
to
3e16fd3
Compare
This is being implemented upstream in OpenAPITools/openapi-generator#16863 |
This PR upgrades openapi-generator in order to get required field validation from upstream: #172 |
This adds required field validation analogous to the required field validation that exists in the Java generator (TODO: link to example in metal-java).
Required fields are validated by:
Templates are updated here: b5c00de
Code is regenerated here: 3e16fd3