This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
feat: API Sync by GitHub Action (2023-10-12) #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ctreatma
reviewed
Oct 12, 2023
| @@ -18,15 +18,16 @@ Name | Type | Description | Notes | |||
| **Status** | Pointer to [**VrfVirtualCircuitStatus**](VrfVirtualCircuitStatus.md) | | [optional] | |||
| **Subnet** | Pointer to **string** | The /30 or /31 subnet of one of the VRF IP Blocks that will be used with the VRF for the Virtual Circuit. This subnet does not have to be an existing VRF IP reservation, as we will create the VRF IP reservation on creation if it does not exist. The Metal IP and Customer IP must be IPs from this subnet. For /30 subnets, the network and broadcast IPs cannot be used as the Metal or Customer IP. | [optional] | |||
| **Tags** | Pointer to **[]string** | | [optional] | |||
| **Vrf** | Pointer to [**Vrf**](Vrf.md) | | [optional] | |||
| **Type** | Pointer to [**VrfIpReservationType**](VrfIpReservationType.md) | | [optional] | |||
There was a problem hiding this comment.
Oh that's weird. Unlike the Java generator, the Go generator doesn't collapse the virtual circuit enums, but it does see a different model with the same contents (VrfIpReservationType is also an enum with vrf as the only allowed value) and use that instead of creating a dedicated, duplicate model.
The end result is functionally the same but it might be nice to be more intentional about it...maybe a single VrfType.yaml schema that we ref in multiple places in the schema, or a bunch of duplicate <thing>Type.yaml to force generators to create duplicate models.
This was referenced Oct 13, 2023
ctreatma
approved these changes
Oct 16, 2023
|
This PR is included in version 0.25.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API Sync PR was automated through GitHub Actions workflow_displatch
on 2023-10-12.