This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
feat: update sync workflow to line up with metal-go #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Jul 17, 2023
| @@ -1880,7 +1880,7 @@ public okhttp3.Call findOrganizationDevicesCall(UUID id, List<String> categories | |||
| Map<String, Object> localVarFormParams = new HashMap<String, Object>(); | |||
|
|
|||
| if (categories != null) { | |||
| localVarCollectionQueryParams.addAll(localVarApiClient.parameterToPairs("multi", "categories", categories)); | |||
| localVarCollectionQueryParams.addAll(localVarApiClient.parameterToPairs("csv", "categories", categories)); | |||
There was a problem hiding this comment.
As part of upgrading the sync job, I made the call to remove the spec stitching step from this repo, the same way we did for metal-go. The stitching step appears to introduce incorrect behavior for URL parameters; the API expects things like include=thing1,thing2 (which corresponds to the "csv" format mentioned on this line) and does not handle include=thing1&include=thing2 (which corresponds to the "multi" format in the old code).
The updated sync workflow performs spec fetching, spec patching, and code generation as separate steps. This enables the workflow to open a draft PR if some of those steps fail so that any issues that come up during sync can be addressed with fewer manual steps.
ctreatma
force-pushed
the
upgrade-sync-workflow
branch
from
1d5fe99 to
9cec2df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated sync workflow performs spec fetching, spec patching, and code generation as separate steps. This enables the workflow to open a draft PR if some of those steps fail so that any issues that come up during sync can be addressed with fewer manual steps.