feat: API Sync by GitHub Action for @ctreatma #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ctreatma
reviewed
Feb 20, 2024
| @@ -12,19 +12,20 @@ Name | Type | Description | Notes | |||
| **Name** | **string** | | | |||
| **Project** | Pointer to **string** | | [optional] | |||
| **Redundancy** | **string** | Either 'primary' or 'redundant'. | | |||
| **Speed** | Pointer to **int64** | A interconnection speed, in bps, mbps, or gbps. For Fabric VCs, this represents the maximum speed of the interconnection. For Fabric VCs (Metal Billed), this can only be one of the following: ''50mbps'', ''200mbps'', ''500mbps'', ''1gbps'', ''2gbps'', ''5gbps'' or ''10gbps'', and is required for creation. For Fabric VCs (Fabric Billed), this field will always default to ''10gbps'' even if it is not provided. For example, ''500000000'', ''50m'', or' ''500mbps'' will all work as valid inputs. | [optional] | |||
| **Speed** | Pointer to **string** | A interconnection speed, in bps, mbps, or gbps. For Fabric VCs, this represents the maximum speed of the interconnection. For Fabric VCs (Metal Billed), this can only be one of the following: ''50mbps'', ''200mbps'', ''500mbps'', ''1gbps'', ''2gbps'', ''5gbps'' or ''10gbps'', and is required for creation. For Fabric VCs (Fabric Billed), this field will always default to ''10gbps'' even if it is not provided. For example, ''500000000'', ''50m'', or' ''500mbps'' will all work as valid inputs. | [optional] | |||
There was a problem hiding this comment.
Input speed properties accept non-numeric values like 10Gbps, so this change is expected/necessary, but it does mean that SDK consumers will have to update code that creates interconnections.
ctreatma
reviewed
Feb 20, 2024
spec/services/metalv1/oas3.patched/components/schemas/InterconnectionPort.yaml.rej
Outdated
Show resolved
Hide resolved
ctreatma
reviewed
Feb 20, 2024
| @@ -15,6 +15,7 @@ Name | Type | Description | Notes | |||
| **Ports** | Pointer to [**[]InterconnectionPort**](InterconnectionPort.md) | For Fabric VCs, these represent Virtual Port(s) created for the interconnection. For dedicated interconnections, these represent the Dedicated Port(s). | [optional] | |||
| **Redundancy** | Pointer to [**InterconnectionRedundancy**](InterconnectionRedundancy.md) | | [optional] | |||
| **ServiceTokens** | Pointer to [**[]FabricServiceToken**](FabricServiceToken.md) | For Fabric VCs (Metal Billed), this will show details of the A-Side service tokens issued for the interconnection. For Fabric VCs (Fabric Billed), this will show the details of the Z-Side service tokens issued for the interconnection. Dedicated interconnections will not have any service tokens issued. There will be one per interconnection, so for redundant interconnections, there should be two service tokens issued. | [optional] | |||
| **AuthorizationCode** | Pointer to **string** | For Fabric VCs (Metal Billed), this allows Fabric to connect the Metal network to any connection Fabric facilitates. Fabric uses this token to be able to give more detailed information about the Metal end of the network, when viewing resources from within Fabric. | [optional] | |||
There was a problem hiding this comment.
@displague @0xch4z it looks like there's a new authorization_code property for interconnections
ctreatma
reviewed
Feb 20, 2024
| @@ -0,0 +1,12 @@ | |||
| properties: | |||
There was a problem hiding this comment.
We should probably stop tracking the fetched spec in git. It makes these PRs more difficult to review.
displague
approved these changes
Feb 23, 2024
0xch4z
approved these changes
Feb 23, 2024
|
This PR is included in version 0.34.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API Sync PR was triggered by @ctreatma through GitHub Actions workflow_displatch
on 2024-02-20.