Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an emdocs command to generate a single page doc #179

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Conversation

displague
Copy link
Member

adds an emdocs command to generate a single page doc.

This is particular interest to @DailyAlice

@cprivitere cprivitere changed the title adds an emdocs command to generate a single page doc DRE-25 adds an emdocs command to generate a single page doc Mar 21, 2022
@cprivitere cprivitere changed the title DRE-25 adds an emdocs command to generate a single page doc Add an emdocs command to generate a single page doc Mar 23, 2022
@DailyAlice
Copy link
Contributor

So I am happy with the format and generation of the emdocs page. Not too sure what the merge plan is for this PR, and I'm also not too sure how to make it pass the tests with the additional markdown file.

Thoughts @displague and @cprivite?

docs/emdocs.md Outdated
@@ -0,0 +1,2379 @@
### metal 2fa
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to include emdocs.md here. I would imagine any external processes that require this file will run the metal emdocs command in the environment where emdocs.md is needed.

@displague displague marked this pull request as ready for review July 6, 2022 16:57
displague added 2 commits July 6, 2022 13:29
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
@displague displague merged commit a5e1018 into main Jul 6, 2022
@displague displague deleted the emdocs branch September 30, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants