Provide metro as well with facility code for hardware reservation #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayushrangwala
had a problem deploying
to
external
GitHub Actions
Failure
codinja1188
reviewed
Aug 9, 2023
internal/hardware/retrieve.go
Outdated
|
|
||
| inc := []string{} | ||
| inc := []string{"facility"} |
There was a problem hiding this comment.
Is it included in standard cases too? If, Yes, need to remove it.
case outputs.FormatJSON, outputs.FormatYAML:
- inc = append(inc, "project", "facility", "device")
+ inc = append(inc, "project", "device")
}
There was a problem hiding this comment.
Yes, updated the switch case to consider facility.metro only as we only need that much.
aayushrangwala
force-pushed
the
aayushrangwala/issue-286
branch
from
6b46d13 to
79f8ab4
Compare
cprivitere
force-pushed
the
aayushrangwala/issue-286
branch
from
79f8ab4 to
80a14f9
Compare
cprivitere
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#286