Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle optional flags correctly in VRF route update #441

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

ctreatma
Copy link
Contributor

@ctreatma ctreatma commented Jan 30, 2024

The test for the VRF route update subcommand was explicitly skipped. I added a helper function to wait for the VRF route to be ready before testing the update subcommand, but when the test was enabled it failed because the subcommand was not capable of updating tags without updating all other VRF route properties.

In addition to enabling the test for the VRF route update subcommand, this updates the subcommand itself so that it only updates a VRF route property if the user set the corresponding CLI flag.

Part of #414

@cprivitere
Copy link
Contributor

Looks like the vrf-route-update-test is panicking after 30 seconds.

@cprivitere cprivitere requested a deployment to internal January 30, 2024 21:58 — with GitHub Actions Abandoned
@displague
Copy link
Member

There have been conversations about adding a --wait argument for create subcommands. The code used in testing could be surfaced as a feature in the future.

@ctreatma
Copy link
Contributor Author

Looks like the vrf-route-update-test is panicking after 30 seconds.

I see a panic happening in a different test due to the test timeout being reached (~1000 seconds) and the VRF route update test failing because the route isn't ready in time. I triggered a re-run of the tests to see if the route update times out again. We may need to extend the test timeout (terraform uses 180m)

test/helper/helper.go Outdated Show resolved Hide resolved
test/helper/helper.go Outdated Show resolved Hide resolved
@ctreatma ctreatma requested a deployment to internal January 31, 2024 17:37 — with GitHub Actions Abandoned
@ctreatma ctreatma requested a deployment to internal January 31, 2024 22:11 — with GitHub Actions Abandoned
Copy link
Contributor

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are flakey but passing in general. The ones added in this PR pass and that's what matters.

@cprivitere cprivitere merged commit 10d7143 into main Jan 31, 2024
7 of 8 checks passed
@cprivitere cprivitere deleted the fix-route-update branch January 31, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants