-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle optional flags correctly in VRF route update #441
Conversation
722eeaf
to
d154c23
Compare
d154c23
to
9adc357
Compare
9adc357
to
b0f8be4
Compare
Looks like the vrf-route-update-test is panicking after 30 seconds. |
There have been conversations about adding a |
I see a panic happening in a different test due to the test timeout being reached (~1000 seconds) and the VRF route update test failing because the route isn't ready in time. I triggered a re-run of the tests to see if the route update times out again. We may need to extend the test timeout (terraform uses |
b0f8be4
to
be77740
Compare
be77740
to
a065b4e
Compare
a065b4e
to
49b4826
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are flakey but passing in general. The ones added in this PR pass and that's what matters.
The test for the VRF route update subcommand was explicitly skipped. I added a helper function to wait for the VRF route to be ready before testing the update subcommand, but when the test was enabled it failed because the subcommand was not capable of updating tags without updating all other VRF route properties.
In addition to enabling the test for the VRF route update subcommand, this updates the subcommand itself so that it only updates a VRF route property if the user set the corresponding CLI flag.
Part of #414