Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

feat: JSON parser with Date reviver #54

Merged
merged 4 commits into from
Dec 15, 2021

Conversation

jorgenholme96
Copy link
Contributor

@jorgenholme96 jorgenholme96 commented Dec 15, 2021

Prerequisites

Please make sure you can check the following boxes:

  • My code follows the code style of this project
  • All new and existing tests passed
  • Fix any eslint/prettier warnings/errors: npm run lint
  • Remove unnecessary console.log (use logInfo logWarn if it's needed)
  • Are variable and function names properly describing what it does?

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

Added a function to replace JSON.parse, which will keep Date types as well.

Also, updated all packages and made the necessary changes.

Jest 27 had some breaking changes. They require the test environment to be jsdom, and some breaking changes for fakeTimers jestjs/jest#11713 (comment)

image

image

@jorgenholme96 jorgenholme96 requested a review from a team December 15, 2021 11:16
@jorgenholme96 jorgenholme96 requested a review from a team as a code owner December 15, 2021 11:16
@jorgenholme96 jorgenholme96 merged commit bb5d9bd into main Dec 15, 2021
@jorgenholme96 jorgenholme96 deleted the feature/jsonParserWithString branch December 15, 2021 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants