Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bad release #245

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix/bad release #245

merged 2 commits into from
Jun 20, 2023

Conversation

mariush2
Copy link
Contributor

@mariush2 mariush2 commented Jun 20, 2023 •
edited
Loading

Was having issues related to CommonJS dependencies which weren't being bundled correctly. Needs to be looked at more at a later time.

Example of error:

Named export 'tokens' not found. The requested module '../../node_modules/@equinor/eds-tokens/dist/esm/base/index.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

@mariush2 mariush2 requested a review from a team June 20, 2023 11:27
@mariush2 mariush2 enabled auto-merge June 20, 2023 11:51
@mariush2 mariush2 merged commit cdf1af2 into main Jun 20, 2023
@mariush2 mariush2 deleted the fix/bad-release branch June 20, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakihle aslakihle aslakihle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariush2 @aslakihle